Expressions container - #882
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
FabianHofmann
left a comment
FabianHofmann
left a comment
There was a problem hiding this comment.
this is extremely non-controversial. let's pull this in. Just to test potential future regressions let's also catch the case that returned and stored expression are the same (as suggested below)
|
|
||
| expr = m.add_expressions(x, name="from_var") | ||
| assert isinstance(expr, LinearExpression) | ||
| assert_linequal(expr, x.to_linexpr()) |
There was a problem hiding this comment.
| assert_linequal(expr, x.to_linexpr()) | |
| assert_linequal(expr, x.to_linexpr()) | |
| assert_linequal(expr, m.expressions["from_var"]) |
|
|
||
| expr = m.add_expressions([(2, x)], name="from_tuples") | ||
| assert isinstance(expr, LinearExpression) | ||
| assert_linequal(expr, 2 * x) |
There was a problem hiding this comment.
| assert_linequal(expr, 2 * x) | |
| assert_linequal(expr, 2 * x) | |
| assert_linequal(expr, m.expressions["from_tuples"]) |
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | test_to_lp[nodal_balance-severity=0] |
2.8 MB | 3.3 MB | -15.43% |
| ⚡ | Memory | test_to_lp[masked-n=100] |
2.7 MB | 1.4 MB | +83.39% |
| ⚡ | Memory | test_to_lp[storage-n=250] |
35.8 MB | 29.4 MB | +21.97% |
| ⚡ | Memory | test_to_lp[rolling-severity=0] |
3.1 MB | 2.7 MB | +14.37% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing feat/expression-container (8461fcb) with master (0f6cdad)
Footnotes
-
175 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
2 participants
Partially closes #881
Note
Initial implementation in #871 was human-generated. I've cherry-picked that and then iterated on it with Claude to close some implementation gaps and to add tests/docs.
Note
This does not address the concept of lazy expressions from #881 as I wanted to keep this PR lightweight and less controversial.
Changes proposed in this Pull Request
Model.add_expressionsregisters aLinearExpressionorQuadraticExpressionunder a name (auto-generated asexpr0,expr1, ... if omitted), accessible afterwards viaModel.expressions(anExpressionscontainer mirroringModel.variables/Model.constraints) and removable viaModel.remove_expressions.Named expressions are persisted by
Model.to_netcdf/linopy.read_netcdfand preserved byModel.copy,copy.copy,copy.deepcopy, and pickling.Checklist
AGENTS.md).doc.doc/release_notes.rstof the upcoming release is included.